Skip to content

espresso and thermoelectric features#1

Open
ptigas wants to merge 5 commits into
mainfrom
feature/espresso-thermoelectric-workflows
Open

espresso and thermoelectric features#1
ptigas wants to merge 5 commits into
mainfrom
feature/espresso-thermoelectric-workflows

Conversation

@ptigas

@ptigas ptigas commented Aug 1, 2025

Copy link
Copy Markdown

Summary

Include a summary of major changes in bullet points:

  • Feature 1
  • Fix 1

Additional dependencies introduced (if any)

  • List all new dependencies needed and justify why. While adding dependencies that bring
    significantly useful functionality is perfectly fine, adding ones that add trivial
    functionality, e.g., to use one single easily implementable function, is frowned upon.
    Justify why that dependency is needed. Especially frowned upon are circular dependencies.

TODO (if any)

If this is a work-in-progress, write something about what else needs to be done.

  • Feature 1 supports A, but not B.

Checklist

Work-in-progress pull requests are encouraged, but please put [WIP] in the pull request
title.

Before a pull request can be merged, the following items must be checked:

  • Code is in the standard Python style.
    The easiest way to handle this is to run the following in the correct sequence on
    your local machine. Start with running ruff and ruff format on your new code. This will
    automatically reformat your code to PEP8 conventions and fix many linting issues.
  • Doc strings have been added in the Numpy docstring format.
    Run ruff on your code.
  • Type annotations are highly encouraged. Run mypy to
    type check your code.
  • Tests have been added for any new functionality or bug fixes.
  • All linting and tests pass.

Note that the CI system will run all the above checks. But it will be much more
efficient if you already fix most errors prior to submitting the PR. It is highly
recommended that you use the pre-commit hook provided in the repository. Simply run
pre-commit install and a check will be run prior to allowing commits.

ptigas and others added 5 commits August 1, 2025 09:49
- Add proper EspressoProfile setup in core.py with working QE script patterns
- Fix bandgap example OutputReference issues using deepcopy approach
- Update ZT calculation to show actual workflow execution errors
- Remove simulation fallbacks per user feedback - workflows now show real failures
- Configure ASE calculator with explicit input_data structure
- Add ASE configuration setup for Quantum ESPRESSO integration

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant